Skip to content

Conversation

@Nagaprasadvr
Copy link
Contributor

@Nagaprasadvr Nagaprasadvr commented Jul 14, 2025

  1. Add InitMultisig
  2. Add InitMultisig2 cpis

@Nagaprasadvr Nagaprasadvr changed the title Add InitMultisig ixs feat : Add InitMultisig ixs Jul 14, 2025
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch from 537b2bf to defd628 Compare July 15, 2025 03:29
@Nagaprasadvr Nagaprasadvr requested a review from ilya-bobyr July 15, 2025 03:30
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch from defd628 to 4fabd0f Compare July 15, 2025 06:44
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch 2 times, most recently from c86acf8 to 291bd0f Compare July 15, 2025 06:53
Copy link
Contributor

@sonicfromnewyoke sonicfromnewyoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch from 291bd0f to 1fb3bee Compare July 15, 2025 06:54
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch from 1fb3bee to 0eafdf5 Compare July 15, 2025 10:19
@Nagaprasadvr Nagaprasadvr requested a review from ilya-bobyr July 15, 2025 10:19
Copy link
Contributor

@ilya-bobyr ilya-bobyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@febo, @joncinque, do anyone of you would like to approve?

@ilya-bobyr ilya-bobyr requested review from febo and joncinque July 17, 2025 03:27
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions, then we can merge this in

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch from 0eafdf5 to b779838 Compare July 18, 2025 11:59
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments/nits. The same apply to initialize_multisig_2.

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch from b779838 to ed203c5 Compare August 11, 2025 04:27
@Nagaprasadvr
Copy link
Contributor Author

i have resolved all the comments @febo

@Nagaprasadvr Nagaprasadvr requested a review from febo August 11, 2025 04:30
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nit.

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-init-multisig-ix branch from ed203c5 to 15542d4 Compare August 13, 2025 03:38
@Nagaprasadvr Nagaprasadvr requested a review from febo August 13, 2025 03:38
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@febo febo merged commit 096a066 into anza-xyz:main Aug 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants