-
Notifications
You must be signed in to change notification settings - Fork 165
feat : Add InitMultisig ixs
#197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
537b2bf to
defd628
Compare
defd628 to
4fabd0f
Compare
c86acf8 to
291bd0f
Compare
sonicfromnewyoke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
291bd0f to
1fb3bee
Compare
1fb3bee to
0eafdf5
Compare
ilya-bobyr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@febo, @joncinque, do anyone of you would like to approve?
joncinque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions, then we can merge this in
0eafdf5 to
b779838
Compare
febo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments/nits. The same apply to initialize_multisig_2.
b779838 to
ed203c5
Compare
|
i have resolved all the comments @febo |
febo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final nit.
ed203c5 to
15542d4
Compare
febo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Uh oh!
There was an error while loading. Please reload this page.