Skip to content

Use Create Account Checked & Create Account with Seed Checked #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 14, 2025
Merged

Use Create Account Checked & Create Account with Seed Checked #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
48f6f6f
use Sysvar rent account
zubayr1 Jul 2, 2025
e4e9837
implement invoke_signed_checked
zubayr1 Jul 17, 2025
01cef1f
removed the checked files
zubayr1 Jul 18, 2025
c709b11
implement with_rent_check constructor
zubayr1 Jul 18, 2025
c518668
fix imports
zubayr1 Jul 18, 2025
3305c0c
Merge branch 'anza-xyz:main' into main
zubayr1 Jul 20, 2025
68cf5be
remove checks
zubayr1 Jul 20, 2025
4d1d45f
Apply suggestions from code review
zubayr1 Jul 23, 2025
f5088a7
Merge branch 'anza-xyz:main' into main
zubayr1 Jul 23, 2025
39eb37d
Merge remote-tracking branch 'pinocchio/main'
zubayr1 Aug 4, 2025
96029a2
fix formatting
zubayr1 Aug 4, 2025
21b9838
Apply suggestions from code review
zubayr1 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion programs/system/src/instructions/create_account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ use pinocchio::{
account_info::AccountInfo,
instruction::{AccountMeta, Instruction, Signer},
program::invoke_signed,
program_error::ProgramError,
pubkey::Pubkey,
sysvars::rent::Rent,
ProgramResult,
};

Expand All @@ -28,7 +30,27 @@ pub struct CreateAccount<'a> {
pub owner: &'a Pubkey,
}

impl CreateAccount<'_> {
impl<'a> CreateAccount<'a> {
#[inline(always)]
pub fn with_minimal_balance(
from: &'a AccountInfo,
to: &'a AccountInfo,
rent_sysvar: &'a AccountInfo,
space: u64,
owner: &'a Pubkey,
) -> Result<Self, ProgramError> {
let rent = Rent::from_account_info(rent_sysvar)?;
let lamports = rent.minimum_balance(space as usize);

Ok(Self {
from,
to,
lamports,
space,
owner,
})
}

#[inline(always)]
pub fn invoke(&self) -> ProgramResult {
self.invoke_signed(&[])
Expand Down
28 changes: 27 additions & 1 deletion programs/system/src/instructions/create_account_with_seed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ use pinocchio::{
account_info::AccountInfo,
instruction::{AccountMeta, Instruction, Signer},
program::invoke_signed,
program_error::ProgramError,
pubkey::Pubkey,
sysvars::rent::Rent,
ProgramResult,
};

Expand Down Expand Up @@ -40,7 +42,31 @@ pub struct CreateAccountWithSeed<'a, 'b, 'c> {
pub owner: &'c Pubkey,
}

impl CreateAccountWithSeed<'_, '_, '_> {
impl<'a, 'b, 'c> CreateAccountWithSeed<'a, 'b, 'c> {
#[inline(always)]
pub fn with_minimal_balance(
from: &'a AccountInfo,
to: &'a AccountInfo,
base: Option<&'a AccountInfo>,
seed: &'b str,
rent_sysvar: &'a AccountInfo,
space: u64,
owner: &'c Pubkey,
) -> Result<Self, ProgramError> {
let rent = Rent::from_account_info(rent_sysvar)?;
let lamports = rent.minimum_balance(space as usize);

Ok(Self {
from,
to,
base,
seed,
lamports,
space,
owner,
})
}

#[inline(always)]
pub fn invoke(&self) -> ProgramResult {
self.invoke_signed(&[])
Expand Down