-
Notifications
You must be signed in to change notification settings - Fork 165
Fix duplicated account parsing #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joncinque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah too bad this snuck in, but looks good to me! I feel silly because I almost asked for a test with duplicates in the previous PR.
I feel the same. There was not a good reason not to include one. |
joncinque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Problem
PR #176 refactored the entrypoint and inlined the processing of accounts, but the parsing of duplicated accounts is wrongly storing the address to an
AccountInfoinstead of anAccount.Solution
Dereference the
AccountInfoto store the address of itsAccount. The PR also includes a test for duplicated account parsing.As a side-effect of the fix, CU consumption improved:
cc: @cavemanloverboy
Fixes #208