Skip to content

feat: add multisig state #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

feat: add multisig state #221

merged 1 commit into from
Aug 18, 2025

Conversation

@Nagaprasadvr
Copy link
Contributor

@Nagaprasadvr Nagaprasadvr commented Aug 14, 2025 •
edited
Loading

  1. Add multisig state to t22 and legacy

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-multisig-state branch from 880fb05 to 428c6ad Compare August 14, 2025 17:06
@Nagaprasadvr Nagaprasadvr changed the title feat: add multisig state and ixs (missing in t22) feat: add multisig state Aug 14, 2025
@Nagaprasadvr Nagaprasadvr changed the base branch from main to febo/token2022-multisig August 14, 2025 17:07
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-multisig-state branch 3 times, most recently from b017ffa to 3c1d305 Compare August 14, 2025 17:14
@Nagaprasadvr Nagaprasadvr changed the title feat: add multisig state feat: add multisig state Aug 15, 2025
febo
febo reviewed Aug 16, 2025
View reviewed changes
febo
febo reviewed Aug 16, 2025
View reviewed changes
febo
febo reviewed Aug 16, 2025
View reviewed changes
febo
febo reviewed Aug 16, 2025
View reviewed changes
febo
febo reviewed Aug 16, 2025
View reviewed changes
febo
febo reviewed Aug 16, 2025
View reviewed changes
febo
febo reviewed Aug 16, 2025
View reviewed changes
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some tweaks that we could use in both Token and Token-2022.

@Nagaprasadvr
Copy link
Contributor Author

Nagaprasadvr commented Aug 16, 2025

Ty ser will add those changes now

febo
febo reviewed Aug 16, 2025
View reviewed changes
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-multisig-state branch from 3c1d305 to 1b492f1 Compare August 16, 2025 13:20
@Nagaprasadvr Nagaprasadvr requested a review from febo August 16, 2025 13:23
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
febo
febo reviewed Aug 17, 2025
View reviewed changes
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a few comments on the accessors.

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-multisig-state branch from 1b492f1 to 3c63d39 Compare August 17, 2025 10:40
@Nagaprasadvr Nagaprasadvr requested a review from febo August 17, 2025 10:40
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-multisig-state branch from 3c63d39 to fcd5aee Compare August 17, 2025 10:41
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-multisig-state branch 4 times, most recently from 46a8f98 to 77a5cd2 Compare August 17, 2025 10:45
@Nagaprasadvr
Copy link
Contributor Author

Nagaprasadvr commented Aug 17, 2025

@febo can we rename len to signers_len ? Or else we need to add is_empty let me know wyt

febo
febo reviewed Aug 18, 2025
View reviewed changes
febo
febo reviewed Aug 18, 2025
View reviewed changes
febo
febo reviewed Aug 18, 2025
View reviewed changes
febo
febo reviewed Aug 18, 2025
View reviewed changes
@febo
Copy link
Collaborator

febo commented Aug 18, 2025

@febo can we rename len to signers_len ? Or else we need to add is_empty let me know wyt

Ah, that is annoying. Using signers_len sounds a good alternative.

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-multisig-state branch from 77a5cd2 to 9d7c0b3 Compare August 18, 2025 16:39
@Nagaprasadvr Nagaprasadvr requested a review from febo August 18, 2025 16:48
febo
febo approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@febo febo merged commit ef45bf3 into anza-xyz:febo/token2022-multisig Aug 18, 2025
11 checks passed
febo added a commit that referenced this pull request Aug 18, 2025
@febo
Revert "feat: add multisig state (#221)"
cbf2aec 
This reverts commit ef45bf3.
@febo febo mentioned this pull request Aug 18, 2025
Merged
febo added a commit that referenced this pull request Aug 18, 2025
@febo
Revert "feat: add multisig state" (#222)
cb3e2a7 
Revert "`feat`: add multisig state (#221)"

This reverts commit ef45bf3.
febo added a commit that referenced this pull request Aug 20, 2025
@febo @rustopian @Nagaprasadvr
token-2022: Add initialize multisig helpers (#220)
4f47ad2 
* Add initialize multisig helpers

* Update programs/token-2022/src/instructions/initialize_multisig_2.rs

Co-authored-by: Peter Keay <[email protected]>

* `feat`: add multisig state (#221)

feat: add multisig state

* Revert "`feat`: add multisig state" (#222)

Revert "`feat`: add multisig state (#221)"

This reverts commit ef45bf3.

---------

Co-authored-by: Peter Keay <[email protected]>
Co-authored-by: Nagaprasad V R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@febo febo febo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nagaprasadvr @febo