pinocchio: Add hint module #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
rustopian
approved these changes
Aug 28, 2025
Comment on lines
+276
to
+277
| #[cold] | ||
| pub const fn cold_path() {} |
Contributor
There was a problem hiding this comment.
#[inline(never)] on cold_path doesn't seem to make a difference - perhaps there are some cases where it would - I'll try a bit more and if so will propose separately.
joncinque
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is possible to add hints to the compiler to help it optimize the code and save CUs – e.g., as it is used in p-token.
Solution
Add a new module
hintwith heper functions. This is similar to the experimental API fromcore::hint.Credits to @cavemanloverboy for this suggestion.