Skip to content

entrypoint: hint case with 2 accounts as unlikely #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: febo/mod-hint
Choose a base branch
from
Draft

entrypoint: hint case with 2 accounts as unlikely #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 29 additions & 24 deletions sdk/pinocchio/src/entrypoint/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ use core::{

use crate::{
account_info::{Account, AccountInfo, MAX_PERMITTED_DATA_INCREASE},
hint::unlikely,
pubkey::Pubkey,
BPF_ALIGN_OF_U128, MAX_TX_ACCOUNTS, NON_DUP_MARKER,
};
Expand Down Expand Up @@ -353,31 +354,35 @@ pub unsafe fn deserialize<const MAX_ACCOUNTS: usize>(
// This is an optimization to reduce the number of jumps required to process the
// accounts. The macro `process_accounts` will generate inline code to process the
// specified number of accounts.
while to_process_plus_one > 5 {
// Process 5 accounts at a time.
process_accounts!(5 => (input, accounts, accounts_slice));
to_process_plus_one -= 5;
}

// There might be remaining accounts to process.
match to_process_plus_one {
5 => {
process_accounts!(4 => (input, accounts, accounts_slice));
}
4 => {
process_accounts!(3 => (input, accounts, accounts_slice));
}
3 => {
process_accounts!(2 => (input, accounts, accounts_slice));
}
2 => {
process_accounts!(1 => (input, accounts, accounts_slice));
if unlikely(to_process_plus_one == 2) {
process_accounts!(1 => (input, accounts, accounts_slice));
} else {
while to_process_plus_one > 5 {
// Process 5 accounts at a time.
process_accounts!(5 => (input, accounts, accounts_slice));
to_process_plus_one -= 5;
}
1 => (),
_ => {
// SAFETY: `while` loop above makes sure that `to_process_plus_one`
// has 1 to 5 entries left.
unsafe { core::hint::unreachable_unchecked() }

// There might be remaining accounts to process.
match to_process_plus_one {
5 => {
process_accounts!(4 => (input, accounts, accounts_slice));
}
4 => {
process_accounts!(3 => (input, accounts, accounts_slice));
}
3 => {
process_accounts!(2 => (input, accounts, accounts_slice));
}
2 => {
process_accounts!(1 => (input, accounts, accounts_slice));
}
1 => (),
_ => {
// SAFETY: `while` loop above makes sure that `to_process_plus_one`
// has 1 to 5 entries left.
unsafe { core::hint::unreachable_unchecked() }
}
}
}

Expand Down