Use solana-define-syscall crate
#262
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
force-pushed
the
febo/use-define-syscall
branch
from
d89e6d5 to
da237d4
Compare
febo
force-pushed
the
febo/remove-log-module
branch
from
b2ae58b to
ecdfada
Compare
febo
force-pushed
the
febo/use-define-syscall
branch
from
da237d4 to
466763b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pinocchio is using common functionality from the SDK, but still duplicates the syscall definitions.
Solution
This PR adds the
solana-define-syscalland removes the duplicated syscall definitions.