Skip to content

Conversation

@febo
Copy link
Collaborator

@febo febo commented Oct 6, 2025

Problem

Currently, pinocchio offers a "std" feature to enable code that requires memory allocation using the std library, although the same functionality is available through alloc.

Solution

Replace the "std" feature by "alloc" and use the alloc library instead.

The "alloc" feature is enabled by default and can be disabled by adding the dependency with default-features = false.

@febo febo added the breaking PR contains breaking changes label Oct 6, 2025
@Aursen
Copy link
Contributor

Aursen commented Oct 8, 2025

The main usage of the old std was for the alloc one (all other usages are available in the core). I think it's a good point to force people to build an sdk outside of the program itself

@febo febo force-pushed the febo/use-define-syscall branch from da237d4 to 466763b Compare October 8, 2025 11:45
@febo febo force-pushed the febo/use-alloc branch 2 times, most recently from e468244 to e7173fc Compare October 8, 2025 13:24
@ilya-bobyr
Copy link
Contributor

Maybe someone else needs to look at this change, but it looks good to me.
If it compiles, it probably is correct :)
If you want, I can approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking PR contains breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants