feat: add support of address-lookup-table program #94
Conversation
| // - [0]: Instruction discriminator (1 byte, u8) (2 for Extend) | ||
|
|
||
| // LOOKUP_TABLE_MAX_ADDRESSES == u8::MAX + 1. | ||
| let mut instruction_data = [0; 8196]; // TODO: huge for stack, maybe forget about no_std and use vector |
There was a problem hiding this comment.
@febo What do you think about such a huge array initialization?
Max addresses to extend is 256 x 32 + 4 for discriminator.
Otherwise I can use Vec<Pubkey>, as it's done in the original program, but we lose no_std for this.
Maybe you have other, better approaches to tackle it? Maybe use features and make 2 realizations for std and no_std ways?
There was a problem hiding this comment.
Vec is just a wrapper for the allocation. both alloc::boxed::Box or alloc::alloc::alloc would allocate on the heap.
There was a problem hiding this comment.
8196 won't fit on the stack, so it needs to be less than 4096 (a bit less than that since there are other things that will go on the stack). Perhaps it would be easier if we define a trait Addresses that represents the instruction data in this case. Then we can have no_std and std implementations for it.
We can use a alloc::vec::Vec for the std variant.
| // - [0]: Instruction discriminator (1 byte, u8) (2 for Extend) | ||
|
|
||
| // LOOKUP_TABLE_MAX_ADDRESSES == u8::MAX + 1. | ||
| let mut instruction_data = [0; 8196]; // TODO: huge for stack, maybe forget about no_std and use vector |
There was a problem hiding this comment.
Vec is just a wrapper for the allocation. both alloc::boxed::Box or alloc::alloc::alloc would allocate on the heap.
| // Instruction data: | ||
| // - [0]: Instruction discriminator (1 byte, u8) (4 for Close) | ||
|
|
||
| let instruction_data = [4u8]; |
| // - [0..4 ]: Instruction discriminator (1 byte, u8) (0 for Create) | ||
| // - [4..12]: Recent Slot | ||
| // - [12 ]: bump seed | ||
| let mut instruction_data = [0; 13]; |
There was a problem hiding this comment.
use MaybeUninit to reduce unnecessary zeroed-out
| // Instruction data: | ||
| // - [0]: Instruction discriminator (1 byte, u8) (3 for Deactivate) | ||
|
|
||
| let instruction_data = [3u8]; |
| // Instruction data: | ||
| // - [0]: Instruction discriminator (1 byte, u8) (1 for Freeze) | ||
|
|
||
| let instruction_data = [1u8]; |
No description provided.