ci: Update publish workflow #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Mar 17, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! Just a suggestion for the caching
joncinque
reviewed
Mar 17, 2025
joncinque
reviewed
Mar 17, 2025
joncinque
approved these changes
Mar 18, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
One more tiny thing, then this can go in!
joncinque
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the "publish" workflow reuses the version bump for both semver checks and publishing. This does not work well for crates that are currently under version
1(e.g.,0.x) since semver rules are applied differently:0.x -> 0.yis a major change, while0.x.y -> 0.x.zis a minor change.Solution
This PR defines a new job responsible to do the semver checks. It works by temporarily setting the new version of the crate according to the version bump specified and running the semver checks on it. If this is successful, then the publishing job is run.
A successful "dry-run" can be seen here: https://github.com/anza-xyz/pinocchio/actions/runs/13920160293
A correctly unsuccessful one is here: https://github.com/anza-xyz/pinocchio/actions/runs/13920266902