Skip to content

msg!: make std optional #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joncinque merged 3 commits into from
Jun 12, 2025
Merged

msg!: make std optional #105

joncinque merged 3 commits into from
Jun 12, 2025

Conversation

@kevinheavey
Copy link
Contributor

@kevinheavey kevinheavey commented Mar 30, 2025 •
edited
Loading

In a follow-up PR I'd like to move sol_log_data here as I noticed it gets used in a few places

Note: this is a breaking change

@joncinque joncinque requested a review from febo March 31, 2025 19:26
febo
febo reviewed Mar 31, 2025
View reviewed changes
febo
febo reviewed Apr 1, 2025
View reviewed changes
febo
febo previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joncinque joncinque added the breaking PR contains breaking changes label Apr 1, 2025
@kevinheavey kevinheavey force-pushed the solana-msg-std-optional branch from 7bda419 to 62b7a9f Compare April 2, 2025 09:21
@febo febo self-requested a review April 3, 2025 16:32
@febo febo dismissed their stale review April 3, 2025 16:34

Waiting for patch releases.

@joncinque joncinque mentioned this pull request Apr 9, 2025
Closed
@joncinque joncinque changed the title make std optional in solana-msg msg!: make std optional Jun 9, 2025
@joncinque
Copy link
Collaborator

joncinque commented Jun 9, 2025

Please rebase and then we can land this, thanks for your patience!

@kevinheavey kevinheavey force-pushed the solana-msg-std-optional branch from 62b7a9f to c637436 Compare June 11, 2025 12:25
@joncinque
Copy link
Collaborator

joncinque commented Jun 11, 2025

There was a breaking change to cargo-sort, so you'll need to install the newest version and then run ./cargo nightly sort --workspace

joncinque
joncinque approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joncinque joncinque merged commit df57ce2 into anza-xyz:master Jun 12, 2025
24 checks passed
febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 21, 2025
@kevinheavey @febo
msg!: make std optional (anza-xyz#105)
5888d12 
* make std optional in solana-msg

* lint

* cargo sort
febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 24, 2025
@publicqi @febo
add memo program (anza-xyz#105)
1284f2d 
* add memo program

* use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS

* nit

* add account info borrowing check

* update docstring and comments

* use &str over &[u8]

* check num_accounts

* avoid unnecessary codegen

* update doc to use &str over &[u8]

* fix doc

* seperate lifetime
febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 25, 2025
@publicqi @febo
add memo program (anza-xyz#105)
ebf75d8 
* add memo program

* use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS

* nit

* add account info borrowing check

* update docstring and comments

* use &str over &[u8]

* check num_accounts

* avoid unnecessary codegen

* update doc to use &str over &[u8]

* fix doc

* seperate lifetime
febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 3, 2025
@publicqi @febo
add memo program (anza-xyz#105)
071c8fd 
* add memo program

* use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS

* nit

* add account info borrowing check

* update docstring and comments

* use &str over &[u8]

* check num_accounts

* avoid unnecessary codegen

* update doc to use &str over &[u8]

* fix doc

* seperate lifetime
febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 18, 2025
@publicqi @febo
add memo program (anza-xyz#105)
669fdfd 
* add memo program

* use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS

* nit

* add account info borrowing check

* update docstring and comments

* use &str over &[u8]

* check num_accounts

* avoid unnecessary codegen

* update doc to use &str over &[u8]

* fix doc

* seperate lifetime
febo pushed a commit to febo/solana-sdk that referenced this pull request Oct 23, 2025
@publicqi @febo
add memo program (anza-xyz#105)
116af77 
* add memo program

* use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS

* nit

* add account info borrowing check

* update docstring and comments

* use &str over &[u8]

* check num_accounts

* avoid unnecessary codegen

* update doc to use &str over &[u8]

* fix doc

* seperate lifetime
febo pushed a commit to febo/solana-sdk that referenced this pull request Nov 19, 2025
@publicqi @febo
add memo program (anza-xyz#105)
7acea1d 
* add memo program

* use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS

* nit

* add account info borrowing check

* update docstring and comments

* use &str over &[u8]

* check num_accounts

* avoid unnecessary codegen

* update doc to use &str over &[u8]

* fix doc

* seperate lifetime
febo added a commit that referenced this pull request Nov 21, 2025
@febo @publicqi @stegaBOB
instruction-view: Add new crate (#401)
6b7745f 
* Add derive address helpers

* Update lock file

* Fix doc links

* Add missing dependency

* Address review comments (#78)

* [wip]: Address review comments

* [wip]: Fix pointer reference

* [wip]: Add logger buffer size tests

* Remove unused

* More logger tests

* Rename program to cpi

* Remove dynamic allocation

* Fixed signed tests

* Fix review comments

* Fix unsigned test case

* Add is_owner_by helper

* Deprecate AccountInfo::realloc (#174)

* Add resize

* Deprecate realloc

* Ignore `zero_init` parameter (#203)

Ignore zero_init parameter

* Remove unused

* Refactor directory structure (#18)

* Use macro rules

* Update directory structure

* Add from_slice helper (#23)

* Fix signer from helpers

* Add signer macro

* Fix doctest

* Add `checked_create_program_address` helper (#30)

* Add unchecked helper

* Fix lint

* Add inline

* Rename to checked

* Cosmetics

* Fix sol log params

* sdk: Improve comments (#64)

* [wip]: Add new scripts

* [wip]: Use matric strategy

* [wip]: Fix members parsing

* [wip]: Add CI env variables

* [wip]: Remove nothrow

* [wip]: Filter changes

* [wip]: Add audit step

* [wip]: Add semver checks

* [wip]: Refactor publish workflow

* [wip]: Refactor

* [wip]: Fix commands

* Fix formatting

* Remove detect changes step

* Review comments

* Fix lint comments

* Expand crate comment

* Ignore crate comment tests

* Add missing docs

* More missing docs

* Add missing release component

* Pin cargo-release version

* Fix merge

* Review comments

* add `seeds` macro (#73)

* use `seeds` macro over `signer` macro

* fix doc to pass doc test

* deprecate  macro

* Address review comments (#78)

* [wip]: Address review comments

* [wip]: Fix pointer reference

* [wip]: Add logger buffer size tests

* Remove unused

* More logger tests

* Rename program to cpi

* Remove dynamic allocation

* Fixed signed tests

* Fix review comments

* Fix unsigned test case

* Add is_owner_by helper

* add memo program (#105)

* add memo program

* use MAX_CPI_ACCOUNTS over MAX_TX_ACCOUNTS

* nit

* add account info borrowing check

* update docstring and comments

* use &str over &[u8]

* check num_accounts

* avoid unnecessary codegen

* update doc to use &str over &[u8]

* fix doc

* seperate lifetime

* Account borrow state check (#147)

* Improve fallback and docs

* Add borrow state check

* Add inline

* Review comments

* Revert doc link merge change

* Add const qualifier (#159)

* Simplify invoke instruction (#154)

* Fix review comments

* Revert offset increment change

* Improve invoke performance

* Add invoke instruction helper

* Typos

* Remove new helpers

* Remove unused

* Address review comments

* Tweak iteration

* More tweaks

* Limit the length of the slice

* Uncomment code

* Validate account length

* Tweak inline attributes

* Use invoke signed unchecked

* Refactor inline

* Renamed to with_bounds

* Update docs

* Fix accounts length test

* Revert change

* Add constant length check

* Review comments

* Fix error variant

* ci: Add spellcheck step (#164)

* Add invoke instruction helper

* Typos

* Remove new helpers

* Remove unused

* Address review comments

* Tweak inline attributes

* Use invoke signed unchecked

* Refactor inline

* Renamed to with_bounds

* Update docs

* Revert change

* Add constant length check

* Add spellcheck step

* Tweak action

* Fix typos

* More fixes

* Yet more fixes

* Fixes

* Add j1 option

* More and more fixes

* Add missing acronym

* Fix merge

* Fix spelling

* Fix spelling

* Clarify the use of constant values (#200)

* Add comments on constants

* Improve offset comments

* Add bitmask to dictionary

* Renamed to field_at_offset

* Feat: Add debug/copy derives and enable missing debug/copy lint (#228)

* Add debug/copy derives and enable missing debug/copy lint

* Update sdk/pinocchio/src/sysvars/rent.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/entrypoint/mod.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/instruction.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/clock.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/fees.rs

* Update sdk/pinocchio/src/sysvars/fees.rs

* Update sdk/pinocchio/src/sysvars/instructions.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/instructions.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/instructions.rs

Co-authored-by: Fernando Otero <[email protected]>

* Update sdk/pinocchio/src/sysvars/clock.rs

* Fix syntax error in Instructions struct derive macro

---------

Co-authored-by: Fernando Otero <[email protected]>

* pinocchio: Add `pubkey_eq` helper (#248)

* Add pubkey_eq helper

* Fix typo

* Update pubkey comparison

* Add proptest

* Add unlikely

* Replace proptest

* Use solana-address

* Fix syscall parameter

* Fix docs

* Update references to pubkey

* Use solana-account-view

* Update dependencies

* Add instruction view

* Update lamports reference

* Tweks

* Add target_arch bpf

* Fix rebase

* Fix lint

* Simplify definition

* Fix doc feature

* Address review comments

* Refactored slice support

* Improve code reuse

* Update msrv check

* More review comments

* Use crate rust-version

* Double quotes

* Fix docs

---------

Co-authored-by: publicqi <[email protected]>
Co-authored-by: Sammy Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joncinque joncinque joncinque approved these changes

@febo febo Awaiting requested review from febo

Assignees

No one assigned

Labels

breaking PR contains breaking changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinheavey @joncinque @febo