Replace std::error::Error with core::error::Error

.github/workflows/main.yml

@@ -83,24 +83,6 @@ jobs:
       - name: Check formatting
         run: ./scripts/check-fmt.sh
 
-  check:
-    name: Cargo check
-    runs-on: ubuntu-latest
-    needs: [sanity]
-    steps:
-      - name: Git Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup Environment
-        uses: ./.github/actions/setup
-        with:
-          nightly-toolchain: true
-          cargo-cache-key: cargo-nightly-check
-          cargo-cache-fallback-key: cargo-nightly
-
-      - name: Run checks
-        run: ./scripts/check-nightly.sh
-
   check-downstream-agave:
     if: false # re-enable after agave uses loader-v3-interface v3
     name: Cargo check Agave master
@@ -203,7 +185,7 @@ jobs:
       - name: Run semver checks
         run: ./scripts/check-semver.sh
 
-  hack:
+  check:
     name: Cargo hack check
     runs-on: ubuntu-latest
     needs: [sanity]
@@ -226,6 +208,30 @@ jobs:
       - name: Run hack check
         run: ./scripts/check-hack.sh
 
+  powerset:
+    name: Cargo check powerset
+    runs-on: ubuntu-latest
+    needs: [sanity]
+    steps:
+      - name: Git Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Environment
+        uses: ./.github/actions/setup
+        with:
+          nightly-toolchain: true
+          clippy: true
+          cargo-cache-key: cargo-nightly-powerset
+          cargo-cache-fallback-key: cargo-nightly
+
+      - name: Install cargo-hack
+        uses: taiki-e/cache-cargo-install-action@v2
+        with:
+          tool: cargo-hack
+
+      - name: Check feature powerset
+        run: ./scripts/check-powerset.sh
+
   minimal-versions:
     name: Check minimal-versions
     runs-on: ubuntu-latest

address-lookup-table-interface/src/error.rs

@@ -15,7 +15,7 @@ pub enum AddressLookupError {
     InvalidLookupIndex,
 }
 
-impl std::error::Error for AddressLookupError {}
+impl core::error::Error for AddressLookupError {}
 
 impl fmt::Display for AddressLookupError {
     fn fmt(&self, f: &mut ::core::fmt::Formatter) -> fmt::Result {

commitment-config/src/lib.rs

@@ -134,7 +134,7 @@ pub enum ParseCommitmentLevelError {
     Invalid,
 }
 
-impl std::error::Error for ParseCommitmentLevelError {}
+impl core::error::Error for ParseCommitmentLevelError {}
 
 impl fmt::Display for ParseCommitmentLevelError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

derivation-path/src/lib.rs

@@ -30,7 +30,7 @@ pub enum DerivationPathError {
     Infallible,
 }
 
-impl std::error::Error for DerivationPathError {}
+impl core::error::Error for DerivationPathError {}
 
 impl fmt::Display for DerivationPathError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
@@ -224,7 +224,7 @@ const QUERY_KEY_KEY: &str = "key";
 #[derive(Clone, Debug, PartialEq, Eq)]
 struct QueryKeyError(String);
 
-impl std::error::Error for QueryKeyError {}
+impl core::error::Error for QueryKeyError {}
 
 impl fmt::Display for QueryKeyError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

hash/src/lib.rs

@@ -94,8 +94,7 @@ pub enum ParseHashError {
     Invalid,
 }
 
-#[cfg(feature = "std")]
-impl std::error::Error for ParseHashError {}
+impl core::error::Error for ParseHashError {}
 
 impl fmt::Display for ParseHashError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

instruction/src/error.rs

@@ -242,10 +242,8 @@ pub enum InstructionError {
     // conversions must also be added
 }
 
-#[cfg(feature = "std")]
-impl std::error::Error for InstructionError {}
+impl core::error::Error for InstructionError {}
 
-#[cfg(feature = "std")]
 impl fmt::Display for InstructionError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match self {
@@ -441,8 +439,7 @@ pub enum LamportsError {
     ArithmeticOverflow,
 }
 
-#[cfg(feature = "std")]
-impl std::error::Error for LamportsError {}
+impl core::error::Error for LamportsError {}
 
 impl fmt::Display for LamportsError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

keypair/src/lib.rs

@@ -303,7 +303,7 @@ pub fn keypair_from_seed(seed: &[u8]) -> Result<Keypair, Box<dyn error::Error>>
 pub fn keypair_from_seed_phrase_and_passphrase(
     seed_phrase: &str,
     passphrase: &str,
-) -> Result<Keypair, Box<dyn std::error::Error>> {
+) -> Result<Keypair, Box<dyn core::error::Error>> {
     keypair_from_seed(&generate_seed_from_seed_phrase_and_passphrase(
         seed_phrase,
         passphrase,

message/Cargo.toml

@@ -61,6 +61,7 @@ frozen-abi = [
     "dep:solana-logger",
     "solana-hash/frozen-abi",
     "solana-pubkey/frozen-abi",
+    "serde",
 ]
 serde = [
     "dep:serde",

message/src/compiled_keys.rs

@@ -23,7 +23,7 @@ pub enum CompileError {
     UnknownInstructionKey(Pubkey),
 }
 
-impl std::error::Error for CompileError {}
+impl core::error::Error for CompileError {}
 
 impl fmt::Display for CompileError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

precompile-error/src/lib.rs

@@ -53,7 +53,7 @@ impl num_traits::ToPrimitive for PrecompileError {
     }
 }
 
-impl std::error::Error for PrecompileError {}
+impl core::error::Error for PrecompileError {}
 
 impl fmt::Display for PrecompileError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

program-error/src/lib.rs

@@ -63,7 +63,7 @@ pub enum ProgramError {
     IncorrectAuthority,
 }
 
-impl std::error::Error for ProgramError {}
+impl core::error::Error for ProgramError {}
 
 impl fmt::Display for ProgramError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
@@ -129,14 +129,14 @@ impl fmt::Display for ProgramError {
 pub trait PrintProgramError {
     fn print<E>(&self)
     where
-        E: 'static + std::error::Error + DecodeError<E> + PrintProgramError + FromPrimitive;
+        E: 'static + core::error::Error + DecodeError<E> + PrintProgramError + FromPrimitive;
 }
 
 #[allow(deprecated)]
 impl PrintProgramError for ProgramError {
     fn print<E>(&self)
     where
-        E: 'static + std::error::Error + DecodeError<E> + PrintProgramError + FromPrimitive,
+        E: 'static + core::error::Error + DecodeError<E> + PrintProgramError + FromPrimitive,
     {
         match self {
             Self::Custom(error) => {

pubkey/src/lib.rs

@@ -102,8 +102,7 @@ impl FromPrimitive for PubkeyError {
     }
 }
 
-#[cfg(feature = "std")]
-impl std::error::Error for PubkeyError {}
+impl core::error::Error for PubkeyError {}
 
 impl fmt::Display for PubkeyError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
@@ -360,8 +359,7 @@ impl FromPrimitive for ParsePubkeyError {
     }
 }
 
-#[cfg(feature = "std")]
-impl std::error::Error for ParsePubkeyError {}
+impl core::error::Error for ParsePubkeyError {}
 
 impl fmt::Display for ParsePubkeyError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

quic-definitions/src/lib.rs

@@ -58,5 +58,5 @@ pub const QUIC_MIN_STAKED_RECEIVE_WINDOW_RATIO: u64 = 128;
 pub const QUIC_MAX_STAKED_RECEIVE_WINDOW_RATIO: u64 = 512;
 
 pub trait NotifyKeyUpdate {
-    fn update_key(&self, key: &Keypair) -> Result<(), Box<dyn std::error::Error>>;
+    fn update_key(&self, key: &Keypair) -> Result<(), Box<dyn core::error::Error>>;
 }

rust-toolchain.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "1.84.1"
+channel = "1.85.1"

sanitize/src/lib.rs

@@ -1,6 +1,6 @@
 //! A trait for sanitizing values and members of over the wire messages.
 
-use {core::fmt, std::error::Error};
+use {core::fmt, core::error::Error};
 
 #[derive(PartialEq, Debug, Eq, Clone)]
 pub enum SanitizeError {

scripts/check-hack.sh

@@ -5,4 +5,4 @@ here="$(dirname "$0")"
 src_root="$(readlink -f "${here}/..")"
 cd "${src_root}"
 
-./cargo nightly hack check --all-targets
+./cargo nightly hack check --all-targets --locked --features frozen-abi --ignore-unknown-features

scripts/check-nightly.sh → scripts/check-powerset.sh

@@ -5,4 +5,4 @@ here="$(dirname "$0")"
 src_root="$(readlink -f "${here}/..")"
 cd "${src_root}"
 
-./cargo nightly check --locked --workspace --all-targets --features frozen-abi
+./cargo nightly hack clippy --feature-powerset --no-dev-deps -- --deny=warnings

sdk/src/pubkey.rs

@@ -9,7 +9,7 @@ pub use solana_pubkey::{
 
 #[deprecated(since = "2.1.0")]
 #[cfg(feature = "full")]
-pub fn write_pubkey_file(outfile: &str, pubkey: Pubkey) -> Result<(), Box<dyn std::error::Error>> {
+pub fn write_pubkey_file(outfile: &str, pubkey: Pubkey) -> Result<(), Box<dyn core::error::Error>> {
     use std::io::Write;
 
     let printable = format!("{pubkey}");
@@ -26,7 +26,7 @@ pub fn write_pubkey_file(outfile: &str, pubkey: Pubkey) -> Result<(), Box<dyn st
 
 #[deprecated(since = "2.1.0")]
 #[cfg(feature = "full")]
-pub fn read_pubkey_file(infile: &str) -> Result<Pubkey, Box<dyn std::error::Error>> {
+pub fn read_pubkey_file(infile: &str) -> Result<Pubkey, Box<dyn core::error::Error>> {
     let f = std::fs::File::open(infile)?;
     let printable: String = serde_json::from_reader(f)?;
 

secp256r1-program/src/lib.rs

@@ -86,7 +86,7 @@ mod target_arch {
     pub fn new_secp256r1_instruction(
         message: &[u8],
         signing_key: EcKey<Private>,
-    ) -> Result<Instruction, Box<dyn std::error::Error>> {
+    ) -> Result<Instruction, Box<dyn core::error::Error>> {
         let group = EcGroup::from_curve_name(Nid::X9_62_PRIME256V1)?;
         if signing_key.group().curve_name() != Some(Nid::X9_62_PRIME256V1) {
             return Err(("Signing key must be on the secp256r1 curve".to_string()).into());

signature/src/error.rs

@@ -1,7 +1,7 @@
 //! Signature error copied directly from RustCrypto's opaque signature error at
 //! https://github.com/RustCrypto/traits/tree/master/signature
 
-#[cfg(feature = "alloc")]
+#[cfg(all(feature = "std", feature = "alloc"))]
 use alloc::boxed::Box;
 use core::fmt::{self, Debug, Display};
 
@@ -11,19 +11,19 @@ use core::fmt::{self, Debug, Display};
 /// could potentially be used recover signing private keys or forge signatures
 /// (e.g. [BB'06]).
 ///
-/// When the `std` feature is enabled, it impls [`std::error::Error`].
+/// When the `std` feature is enabled, it impls [`core::error::Error`].
 ///
 /// When the `alloc` feature is enabled, it supports an optional
-/// [`std::error::Error::source`], which can be used by things like remote
+/// [`core::error::Error::source`], which can be used by things like remote
 /// signers (e.g. HSM, KMS) to report I/O or auth errors.
 ///
 /// [BB'06]: https://en.wikipedia.org/wiki/Daniel_Bleichenbacher
 #[derive(Default)]
 #[non_exhaustive]
 pub struct Error {
     /// Source of the error (if applicable).
-    #[cfg(feature = "std")]
-    source: Option<Box<dyn std::error::Error + Send + Sync + 'static>>,
+    #[cfg(all(feature = "std", feature = "alloc"))]
+    source: Option<Box<dyn core::error::Error + Send + Sync + 'static>>,
 }
 
 impl Error {
@@ -33,9 +33,9 @@ impl Error {
     /// errors e.g. signature parsing or verification errors. The intended use
     /// cases are for propagating errors related to external signers, e.g.
     /// communication/authentication errors with HSMs, KMS, etc.
-    #[cfg(feature = "std")]
+    #[cfg(all(feature = "std", feature = "alloc"))]
     pub fn from_source(
-        source: impl Into<Box<dyn std::error::Error + Send + Sync + 'static>>,
+        source: impl Into<Box<dyn core::error::Error + Send + Sync + 'static>>,
     ) -> Self {
         Self {
             source: Some(source.into()),
@@ -44,12 +44,12 @@ impl Error {
 }
 
 impl Debug for Error {
-    #[cfg(not(feature = "std"))]
+    #[cfg(not(all(feature = "std", feature = "alloc")))]
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.write_str("signature::Error {}")
     }
 
-    #[cfg(feature = "std")]
+    #[cfg(all(feature = "std", feature = "alloc"))]
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.write_str("signature::Error { source: ")?;
 
@@ -69,15 +69,15 @@ impl Display for Error {
     }
 }
 
-#[cfg(feature = "std")]
-impl From<Box<dyn std::error::Error + Send + Sync + 'static>> for Error {
+#[cfg(all(feature = "std", feature = "alloc"))]
+impl From<Box<dyn core::error::Error + Send + Sync + 'static>> for Error {
     fn from(source: Box<dyn std::error::Error + Send + Sync + 'static>) -> Error {
         Self::from_source(source)
     }
 }
 
 #[cfg(feature = "std")]
-impl std::error::Error for Error {
+impl core::error::Error for Error {
     fn source(&self) -> Option<&(dyn core::error::Error + 'static)> {
         self.source
             .as_ref()

signer/src/lib.rs

@@ -22,7 +22,7 @@ pub enum PresignerError {
     VerificationFailure,
 }
 
-impl std::error::Error for PresignerError {}
+impl core::error::Error for PresignerError {}
 
 impl fmt::Display for PresignerError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
@@ -49,8 +49,8 @@ pub enum SignerError {
     TooManySigners,
 }
 
-impl std::error::Error for SignerError {
-    fn source(&self) -> ::core::option::Option<&(dyn std::error::Error + 'static)> {
+impl core::error::Error for SignerError {
+    fn source(&self) -> ::core::option::Option<&(dyn core::error::Error + 'static)> {
         match self {
             Self::KeypairPubkeyMismatch => None,
             Self::NotEnoughSigners => None,