Skip to content

program-memory: Add missing unsafe #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

program-memory: Add missing unsafe #120

wants to merge 3 commits into from

Conversation

febo
Copy link
Contributor

@febo febo commented Apr 2, 2025 •
edited
Loading

Program

Currently there are a few functions on program-memory crate that are missing the "unsafe" qualifier.

Solution

Add the missing "unsafe". This PR also adds the no_std attribute to the crate since it is already a no_std "friendly" crate.

@febo febo requested a review from joncinque April 2, 2025 19:51
@febo febo marked this pull request as ready for review April 2, 2025 19:51
@febo febo added the breaking PR contains breaking changes label Apr 2, 2025
joncinque
joncinque reviewed Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the breaking tag, we'll wait to merge this once all of the deprecations have been published.

@joncinque joncinque mentioned this pull request Apr 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking PR contains breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@febo @joncinque