Skip to content

add config-interface crate #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link
Contributor

Problem: some crates (particularly solana-account-decoder) depend on solana-config-program, which is very heavy because it depends on solana-program-runtime.

Solution:

  • rip out everything except the processor and date_instruction.rs (deprecated and doesn't seem to be used elsewhere).
  • make serde and bincode optional in the new crate

Once this is published we would then replace the relevant code in agave/programs/config with re-exports

@joncinque
Copy link
Collaborator

This makes sense to me, thanks! Can you move this PR to https://github.com/solana-program/config instead though?

@buffalojoec
Copy link
Contributor

The existing client in https://github.com/solana-program/config does not depend on solana-program-runtime.

@kevinheavey
Copy link
Contributor Author

It depends on solana-program though

@febo
Copy link
Contributor

febo commented Apr 3, 2025

I think we can follow the same approach of solana-program/system and solana-program/stake – i.e., have an interface crate alongside the clients and program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants