add config-interface crate #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This makes sense to me, thanks! Can you move this PR to https://github.com/solana-program/config instead though? |
Contributor
|
The existing client in https://github.com/solana-program/config does not depend on |
Contributor
Author
|
It depends on solana-program though |
Contributor
|
I think we can follow the same approach of solana-program/system and solana-program/stake – i.e., have an interface crate alongside the clients and program. |
Collaborator
|
Can this be closed since solana-program/config#47 landed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: some crates (particularly solana-account-decoder) depend on solana-config-program, which is very heavy because it depends on solana-program-runtime.
Solution:
Once this is published we would then replace the relevant code in agave/programs/config with re-exports