-
Notifications
You must be signed in to change notification settings - Fork 53
program-entrypoint: Add no_std
attribute
#131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
program-entrypoint: Add no_std
attribute
#131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – just one nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Adding |
Good point! When the cc: @joncinque |
Need to consider the potential issue with the panic handler.
Problem
Currently the
program-entrypoint
crate isno_std
"friendly" but does not have the crate attribute and used reexports fromcore
andalloc
instd
Solution
core
andalloc
instead of reexports fromstd