CI: Add a comment if a PR touches sysvars #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem As noted at anza-xyz/agave#428 (comment), it's possible to update the Rust client and forget to update the JS client. #### Summary of changes Copy the solution at https://github.com/orgs/community/discussions/69944#discussioncomment-10796276, but adapt it to our needs. NOTE: I'll try updating some paths to see if this works.
|
Taking a look at https://github.com/marketplace/actions/comment-pull-request#permissions, I don't think I'll be able to properly test this, but I think the perms will be correct once we land this. I can open a test PR after this |
steveluscher
previously approved these changes
Apr 11, 2025
|
But yeah also, forks. |
Oh yeah, good call, updated to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noted at
anza-xyz/agave#428 (comment), it's possible to update the Rust client and forget to update the JS client.
Summary of changes
Copy the solution at https://github.com/orgs/community/discussions/69944#discussioncomment-10796276, but adapt it to our needs.
NOTE: I'll try updating some paths to see if this works.Testing failed, oh well