Skip to content

Use sol_get_sysvar instead of sol_get_<NAME>_sysvar #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 19, 2025
Merged

Use sol_get_sysvar instead of sol_get_<NAME>_sysvar #257

merged 18 commits into from
Sep 19, 2025

Conversation

@rustopian
Copy link
Contributor

@rustopian rustopian commented Jul 30, 2025

Issue #235

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@rustopian rustopian marked this pull request as ready for review August 4, 2025 09:18
@rustopian rustopian marked this pull request as draft August 4, 2025 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@rustopian
Copy link
Contributor Author

rustopian commented Aug 6, 2025

CI fix waiting on 264

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@rustopian rustopian marked this pull request as ready for review August 14, 2025 15:20
@rustopian rustopian marked this pull request as draft August 14, 2025 15:21
febo
febo reviewed Aug 16, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@rustopian rustopian marked this pull request as ready for review August 20, 2025 10:23
@rustopian rustopian requested a review from joncinque September 17, 2025 07:47
joncinque
joncinque reviewed Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Mostly tiny things

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

If this PR represents a change to the sysvar layout, please open a follow-up PR to update the JavaScript client @solana/sysvars (example)
Thank you for keeping the JavaScript clients in sync with the Rust clients.

@rustopian rustopian requested review from febo and joncinque September 18, 2025 12:41
joncinque
joncinque approved these changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@rustopian rustopian requested review from grod220 and removed request for febo September 18, 2025 14:23
@rustopian rustopian merged commit c86fd28 into anza-xyz:master Sep 19, 2025
26 checks passed
@rustopian rustopian deleted the 235-sol-get-sysvar branch September 19, 2025 20:05
febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 21, 2025
@rustopian @febo
Use sol_get_sysvar instead of sol_get_<NAME>_sysvar (anza-xyz#257)
8c93a2e 
* support deprecated attribute in `define_syscall` macro
* still leaves old deprecated macro for fees sysvar
* `impl_get_sysvar` macro tests across sysvars
@joncinque joncinque mentioned this pull request Oct 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@febo febo febo left review comments

@joncinque joncinque joncinque approved these changes

@grod220 grod220 Awaiting requested review from grod220

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rustopian @febo @joncinque