Bump ed25519-dalek to 2.1.1, ed25519-dalek-bip32 to 0.3.0 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
from
30b1850 to
4dce186
Compare
|
How does this affect performance (the bench should tell us that, I think). |
|
Looks like the new version is faster. Found this in the CI bench output https://github.com/anza-xyz/solana-sdk/actions/runs/13304474459/job/37152326064?pr=26: Meanwhile in another unrelated PR: https://github.com/anza-xyz/solana-sdk/actions/runs/13344518453/job/37273344074?pr=40 |
juchiast
reviewed
Mar 25, 2025
| @@ -76,12 +71,12 @@ impl Keypair { | |||
|
|
|||
| /// Returns this `Keypair` as a base58-encoded string | |||
| pub fn to_base58_string(&self) -> String { | |||
| bs58::encode(&self.0.to_bytes()).into_string() | |||
| bs58::encode(&self.to_bytes()).into_string() | |||
| } | |||
|
|
|||
| /// Gets this `Keypair`'s SecretKey | |||
| pub fn secret(&self) -> &ed25519_dalek::SecretKey { | |||
There was a problem hiding this comment.
I think this should just return [u8; 32] directly, skip the type alias of ed25519-dalek.
There was a problem hiding this comment.
That would have security implications but I'm not the right person to comment on it
juchiast
reviewed
Mar 25, 2025
keypair/src/lib.rs
Outdated
| @@ -271,11 +262,9 @@ pub fn keypair_from_seed(seed: &[u8]) -> Result<Keypair, Box<dyn error::Error>> | |||
| if seed.len() < ed25519_dalek::SECRET_KEY_LENGTH { | |||
| return Err("Seed is too short".into()); | |||
| } | |||
| let secret = ed25519_dalek::SecretKey::from_bytes(&seed[..ed25519_dalek::SECRET_KEY_LENGTH]) | |||
| let secret_key = ed25519_dalek::SecretKey::try_from(&seed[..ed25519_dalek::SECRET_KEY_LENGTH]) | |||
There was a problem hiding this comment.
this function never fail, should call unwrap here
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
from
24cb6ce to
c15a222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from anza-xyz/agave#3088
Summary of Changes
Keypair::generatenow relies on traits from a newer version of the rand crate - it no longer works with rand 0.7.