Skip to content

Conversation

@vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Sep 11, 2025

The main motivation is the change kevinheavey/five8@327e168a533d which marks the crate as no_std. That will allow all SDK crates that depend on it to be built without std as well.

@vadorovsky vadorovsky marked this pull request as ready for review September 11, 2025 14:39
@joncinque
Copy link
Collaborator

We can land this if needed, but how about we just bump all the five8 deps to v1? kevinheavey/five8@39133e1

The main motivation is the change kevinheavey/five8@327e168a533d which
marks the crate as `no_std`. That will allow all SDK crates that depend
on it to be built without std as well.
@vadorovsky vadorovsky changed the title build(deps): Bump five8_core to 0.1.2 build(deps): Bump five8 crates to 1.0.0 Sep 15, 2025
@vadorovsky
Copy link
Member Author

@joncinque Good idea, done. It works nicely.

Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vadorovsky vadorovsky merged commit 60e08c2 into anza-xyz:master Sep 15, 2025
25 checks passed
@vadorovsky vadorovsky deleted the update-five8_core branch September 15, 2025 15:40
febo pushed a commit to febo/solana-sdk that referenced this pull request Sep 21, 2025
build(deps): Bump five8 crates to 1.0.0

The main motivation is the change kevinheavey/five8@327e168a533d which
marks the crate as `no_std`. That will allow all SDK crates that depend
on it to be built without std as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants