feat: add no_std support for cluster-type crate
#337
Conversation
vadorovsky
left a comment
vadorovsky
left a comment
There was a problem hiding this comment.
Amazing stuff! Let's add that crate to scripts/check-no-std.sh, to make sure it's tested in CI.
sonicfromnewyoke
force-pushed
the
sonic/no-std-cluster-type
branch
from
22fcbb5 to
aa5c23d
Compare
|
looks like this MR is blocked by #323 error[E0599]: no method named `fetch_add` found for struct `core::sync::atomic::AtomicU64` in the current scope
--> atomic-u64/src/lib.rs:15:20
|
15 | self.0.fetch_add(v, atomic::Ordering::Relaxed)
| ^^^^^^^^^ method not found in `core::sync::atomic::AtomicU64`
Some errors have detailed explanations: E0463, E0599.
For more information about an error, try `rustc --explain E0463`. |
vadorovsky
force-pushed
the
sonic/no-std-cluster-type
branch
from
aa5c23d to
8c74f33
Compare
|
I went ahead and rebased it. #323 fixed the error you mentioned, but then the next one appeared (we were using |
many thanks. Will take a look shortly |
|
@joncinque I'll let you review, since I touched the code 🙂 |
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good overall! Just a few small things
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
A few more questions, sorry for the back and forth
The only use of `alloc` was construction of the error message. To make the crate build for the upstream eBPF targets and without `alloc`, use `thiserror` without default features for the error enum.
Co-authored-by: Jon C <[email protected]>
sonicfromnewyoke
force-pushed
the
sonic/no-std-cluster-type
branch
from
04e88fa to
87e41f9
Compare
3 participants
Problem
solana-cluster-typecrate has nono_stdsupportSummary of Changes
stdfeature and make it enabled by defaultserdeandsolana-hashand and their std features in std mode of thesolana-cluster-typecratesolana-genesis-configcrate dependency to not use std featuresolana-cluster-type