[bn254] Add _be suffix to BE compress/decompress functions #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@samkim-crypto I set the deprecated since version to |
| } | ||
| } | ||
|
|
||
| pub fn alt_bn128_g1_compress_be( |
Contributor
There was a problem hiding this comment.
alt_bn128_g1_compress is not invoking alt_bn128_g1_compress_be to save on CUs here, correct?
Contributor
Author
There was a problem hiding this comment.
If it was invoking alt_bn128_g1_compress_be here, then the length of the input would be checked, which is not the case in the original logic.
Contributor
There was a problem hiding this comment.
Ah yes makes sense to me. Thanks!
samkim-crypto
previously approved these changes
Nov 16, 2025
samkim-crypto
force-pushed
the
be-suffix
branch
from
e2d0d73 to
0639492
Compare
samkim-crypto
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #332, where I forgot to add the
_besuffix to the BE compress/decompress functions.I also changed the input to a sized array for the new functions, as in #334.