Document security hazards of system_interface::instruction::create_account
#416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Nov 7, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Also asking for a recommendation about create_account_allow_prefund, but maybe we wait to include that until it's been enabled
Comment on lines
+315
to
+320
| /// # Security issues | ||
| /// | ||
| /// Using this function is a security issue if the `to_address` is predictable | ||
| /// by an attacker. The attacker can prefund the address with lamports and | ||
| /// thereby prevent the successful execution of the `create_account` call. This | ||
| /// can DoS an on-chain program. |
Collaborator
There was a problem hiding this comment.
This makes sense to me! Should we add a call-out to use create_account_allow_prefund to avoid the error? cc @rustopian
Contributor
There was a problem hiding this comment.
Excellent. Yes, we should recommend CreateAccountAllowPrefund here in any case where to_address could be predictable ... once the feature is active.
rustopian
approved these changes
Nov 7, 2025
joncinque
approved these changes
Nov 7, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.