v3: Re-export v4 hash #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
commented
Oct 31, 2025
| [profile.dev.build-override] | ||
| opt-level = 1 | ||
|
|
||
| [patch.crates-io] |
Contributor
Author
There was a problem hiding this comment.
These are all solana-* dependencies from the hash crate so they will always use the repository version instead of crates.io ones.
febo
commented
Nov 4, 2025
scripts/test-miri.sh
Outdated
| # Note: fixed version of solana-hash is needed here to avoid | ||
| # dependency resolution issues since v3 just re-exports | ||
| # v4 of the `solana-hash` crate. | ||
| ./cargo nightly miri test -p [email protected] -p solana-account-info |
Contributor
Author
There was a problem hiding this comment.
This was needed since miri was complaining that there were 2 solana-hash crates available.
Contributor
Author
There was a problem hiding this comment.
I think we can actually remove solana-hash from this script, since there are no tests in the crate.
joncinque
approved these changes
Nov 5, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! (assuming CI passes this time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was a major version of
solana-hashsince features were created so dependencies are optional and the crate was madeno_stdcompatible. Although the types between the version have not changed, the major bump makes them to be considered different.Solution
Follow the semver trick and re-export the v4 type on v3, so they will be considered the same type.