Skip to content

nit: refactor: removes unwrap by using a map instead #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

nit: refactor: removes unwrap by using a map instead #425

merged 2 commits into from
Nov 4, 2025

Conversation

@akhi3030
Copy link
Contributor

@akhi3030 akhi3030 commented Nov 4, 2025 •
edited
Loading

I reading some code and noticed that we can write this more cleanly without an unwrap.

@akhi3030 akhi3030 changed the title wip nit: refactor: removes unwrap by using a map instead Nov 4, 2025
@akhi3030 akhi3030 marked this pull request as ready for review November 4, 2025 15:46
@akhi3030 akhi3030 requested a review from buffalojoec November 4, 2025 15:46
@akhi3030 akhi3030 enabled auto-merge (squash) November 4, 2025 15:46
buffalojoec
buffalojoec approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akhi3030 akhi3030 merged commit ea08ee9 into master Nov 4, 2025
26 checks passed
@akhi3030 akhi3030 deleted the akhi3030/nit-rm-unwrap branch November 4, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhi3030 @buffalojoec