Fix hasher performance degredation caused by rust upgrade #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
approved these changes
Nov 4, 2025
Collaborator
|
I'm trying to reproduce Rory's results in this issue, I think it would be good for us to figure that out before merging this PR. Discussion still happening over there |
steviez
approved these changes
Nov 4, 2025
Collaborator
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
I'm trying to reproduce Rory's results in this issue, I think it would be good for us to figure that out before merging this PR. Discussion still happening over there
Ok, Rory and I figured out the discrepancy between our results (details back in the Agave issue) so I feel comfortable shipping this one now
joncinque
approved these changes
Nov 4, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
This is great, thanks for digging in and finding a fix!
joncinque
added
the
backport maintenance/v3.x
Collaborator
|
We're in the process of publishing breaking changes on the sdk, so I'll backport to v3 so Agave can get the fix quicker |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
(cherry picked from commit f544553)
6 tasks
joncinque
pushed a commit
that referenced
this pull request
Nov 4, 2025
… by rust upgrade (#427) Fix hasher performance degredation caused by rust upgrade (#426) (cherry picked from commit f544553) Co-authored-by: Rory Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement:
When upgrading Rust from 1.86 to 1.87, it was found the performance of the PoH hashing degraded. Since then, all rust upgrades have been blocked.
Solution
After analysis it was found that inlining differences during the LLVM compilation were causing the performance difference. By force inlining the performance improved in current nightly to better than 1.87
Results were verified with proof of hash bench:
1.86 without force inline
1.86 with force inline
nightly without force inline
nightly with force inline
And on chain:
Below shows performance with nightly
Before the restart, nightly without the fix is running.
After the restart, nightly with the fix is running.
It is also better than 1.86 (which is not shown on the graph)
anza-xyz/agave#8869