-
Notifications
You must be signed in to change notification settings - Fork 157
v3: CI: Pin cargo-release and cargo-semver-checks #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#### Problem cargo-semver-checks now requires Rust 1.89, but the v3 branch is still on 1.88. #### Summary of changes Pin cargo-semver-checks to the last known working version. Do the same with cargo-release, since that just upgraded to Rust 1.89.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha nice, I was just looking into this / about to create a PR when I saw yours.
Should we also remove this statement so that we get the semver check to run in normal CI ? I didn't git blame my way to see why it was disabled in the first place, but the comment there would suggest we could re-enable it now
solana-sdk/.github/workflows/main.yml
Lines 186 to 204 in f544553
| if: false # enable after 2.2.0 is cut | |
| name: Check semver | |
| runs-on: ubuntu-latest | |
| needs: [sanity] | |
| steps: | |
| - name: Git Checkout | |
| uses: actions/checkout@v4 | |
| - name: Setup Environment | |
| uses: ./.github/actions/setup | |
| with: | |
| stable-toolchain: true | |
| cargo-cache-key: cargo-stable-semver | |
| cargo-cache-fallback-key: cargo-stable | |
| - name: Install cargo-semver-checks | |
| uses: taiki-e/cache-cargo-install-action@v2 | |
| with: | |
| tool: cargo-semver-checks |
For example, I can see that Check semver was skipped for this PR:
https://github.com/anza-xyz/solana-sdk/actions/runs/19083195426/job/54517055088?pr=428
|
Running semver-checks on every PR can be very noisy, especially when the repo is in a broken (EDIT: meaning, contains breaking changes) state, so we've decided to only run it on publish. I'll remove that check. Feel free to approve this PR if you want though 😉 |
febo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
steviez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running semver-checks on every PR can be very noisy, especially when the repo is in a broken (EDIT: meaning, contains breaking changes) state, so we've decided to only run it on publish. I'll remove that check.
Got it, figured there may be some context I was missing
Feel free to approve this PR if you want though 😉
Don't mind if I do 😆
Problem
cargo-semver-checks now requires Rust 1.89, but the v3 branch is still on 1.88.
Summary of changes
Pin cargo-semver-checks to the last known working version. Do the same with cargo-release, since that just upgraded to Rust 1.89.