CI: Remove disabled checks for semver and downstream #429
+0
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The main CI job has two jobs disabled: semver-checks and downstream agave checks. The semver-checks job on every PR is more trouble than it's worth, so we only run it before publishing, when semver breakage truly matters. The downstream Agave check has a similar problem, where it quickly goes red. #### Summary of changes Just remove them. I kept the downstream testing script, since it can still be useful in certain situations, just not in CI. The semver-check script is pretty useless though, so I removed that.
steviez
approved these changes
Nov 4, 2025
Collaborator
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
The semver-checks job on every PR is more trouble than it's worth, so we only run it before publishing, when semver breakage truly matters.
Given that you pick major|minor|patch in the publish GH action, defering to publish seems reasonable.
Just remove them. I kept the downstream testing script, since it can still be useful in certain situations, just not in CI.
Works for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The main CI job has two jobs disabled: semver-checks and downstream agave checks.
The semver-checks job on every PR is more trouble than it's worth, so we only run it before publishing, when semver breakage truly matters.
The downstream Agave check has a similar problem, where it quickly goes red.
Summary of changes
Just remove them. I kept the downstream testing script, since it can still be useful in certain situations, just not in CI. The semver-check script is pretty useless though, so I removed that.