hash: Add semver-checks lints #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
force-pushed
the
add-semver-checks-lints
branch
from
48beeb7 to
b0dc426
Compare
febo
force-pushed
the
add-semver-checks-lints
branch
from
b0dc426 to
7b091c7
Compare
joncinque
approved these changes
Nov 5, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for digging into this, looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
hashcrate now re-exports the types fromhash@v4to maintain compatibility between the different major versions. But it is still not possible to publish a patch version from the maintenance/v3.x branch since semver-checks does not support checking cross-crate elements and reports the re-exports as missing/breaking changes.This is known limitation of semver-cheks:
Solution
Disable the semver-checks lints for the
hashcrate so the re-exported elements are not flagged as missing.Unsuccessful semver-checks (current): https://github.com/anza-xyz/solana-sdk/actions/runs/19088345538/job/54533431155
Successful semver-checks (this PR): https://github.com/febo/solana-sdk/actions/runs/19100305658/job/54570359447