v3/address: Re-export v2 #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Nov 5, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just a fly-by, but I looked through and everything looks good to me. Looks like there's just a small fix required for the no-std build script
Contributor
Author
Yeah, we need to specify a version for duplicated crates. Fixed here: 3e33e4f |
febo
commented
Nov 6, 2025
| alloc = [] | ||
| syscalls = ["dep:solana-define-syscall", "error"] | ||
| atomic = ["solana-address-v2/atomic"] | ||
| borsh = ["solana-address-v2/borsh", "alloc"] |
Contributor
Author
There was a problem hiding this comment.
@joncinque Added reference to other features so the powerset generated is smaller – looks redundant but reduces the number of combinations from 33k+ to ~3k. Without this, CI was running for more than 1 hour evaluating feature combinations and still had more combinations to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was a major version of
solana-addresssince a"copy"feature was created. Although the type between the versions has not changed, the major bump makesAddressto be considered different.Solution
Follow the semver trick and re-export the v2 type on v1, so they will be considered the same type.