fix(transaction): apply features to solana-transaction-error dep
#437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `serde` feature is applied to the `solana-transaction` it should also be applied to `solana-transaction-error`. Also do the same for the `frozen-abi` feature.
joncinque
previously approved these changes
Nov 7, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
This makes sense, considering solana-transaction re-exports solana-transaction-error. Thanks for your contribution!
Collaborator
|
Can you just |
Contributor
Author
|
All done! I had to install |
joncinque
approved these changes
Nov 7, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround! And yeah sorry, we use a few external tools in CI
apfitzge
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
serdefeature is applied to thesolana-transactionit should also be applied tosolana-transaction-error.Also do the same for the
frozen-abifeature.