ci: Fix proc-macro test on publish #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
force-pushed
the
fix-proc-macro-test
branch
from
6518924 to
dbe82e6
Compare
joncinque
approved these changes
Nov 7, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Nice, thanks for fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#417 inverted the proc-macro test so semver-checks would run on library crates, but it broke the test for proc-macro crates.
Solution
Modify the test to look for a
"proc-macro"attribute under the"[lib]"section. It also fixes a typo that made the test to (incorrectly) run on any crate:inputs.package-path->inputs.package_pathThe problem with the current behaviour can be seen here: https://github.com/anza-xyz/solana-sdk/actions/runs/19166485673/job/54788310868
A successful run on a proc-macro crate: https://github.com/febo/solana-sdk/actions/runs/19168994216/job/54796492385
A successful run on a lib crate: https://github.com/febo/solana-sdk/actions/runs/19169075552/job/54796765269