ci: improve test-frozen-abi script #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-stones
previously approved these changes
Nov 12, 2025
Contributor
tao-stones
left a comment
tao-stones
left a comment
There was a problem hiding this comment.
looks good for metadata
joncinque
reviewed
Nov 13, 2025
Collaborator
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Just a small suggestion that might simplify the change
scripts/test-frozen-abi.sh
Outdated
Comment on lines
8
to
13
| packages=$(./cargo nightly metadata --no-deps --format-version=1 | jq -r '.packages[] | select(.features | has("frozen-abi")) | .name') | ||
| for package in $packages; do | ||
| echo "::group::./cargo nightly test -p $package --features frozen-abi --lib -- test_abi_ --nocapture" | ||
| ./cargo nightly test -p "$package" --features frozen-abi --lib -- test_abi_ --nocapture | ||
| echo "::endgroup::" | ||
| done |
Collaborator
There was a problem hiding this comment.
If you want to use cargo hack, we can simplify the change to simply:
./cargo nightly hack --features frozen-abi --ignore-unknown-features test --lib -- test_abi_ --nocapture
What do you think? We'll also need to install cargo-hack for this step in CI if we go this route
tao-stones
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that some crates' frozen-abi features can't be run individually. The reason is that our tests run them all together, which allows them to rely on tainted packages and hide potential errors. As you can see in https://github.com/anza-xyz/solana-sdk/actions/runs/19302341784/job/55200264398, it caught a missing
solana_short_vec/frozen-abiin the message.Summary of Changes
test frozen-abi crate by crate