Adding best practices to the release flow#573
Conversation
joncinque
left a comment
There was a problem hiding this comment.
Makes sense to me! We have a bunch of publishes to get out with #571, so can we wait until those publishes are done before adding this?
I have a small worry about how annoying this process will be if we ever need to make a breaking change at solana-address or something, which essentially requires publishing ~100 crates. Doing that by myself took a few days of clicking a button every 5 minutes.
Maybe at that point we'll need to create a new workflow which just does all the publishes in order. Is that the plan for Agave?
| id-token: write | ||
| attestations: write |
There was a problem hiding this comment.
I'm assuming we don't want artifact metadata storage records, but just making sure: does this also need artifact-metadata: write?
https://github.com/actions/attest-build-provenance?tab=readme-ov-file#usage
There was a problem hiding this comment.
good spot, yep we need this here
Problem
We should use trusted publishing and environments across all our repos, so adding them here. Very similar to Pinocchio one, but with the addition of SLSA and a GitHub app for releases, similar to WinCode.
Solution
I am adding the following:
prodenvironment that needs 2 approvals before runningWhat needs to be done before merging:
prodenv