sdk: Remove dummy-for-ci-check feature #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The `dummy-for-ci-check` feature was added to avoid breaking Agave's CI when the sdk was put into its own workspace, but it isn't actually needed by `solana-sdk` now that it's out of the Agave repo. #### Summary of changes Remove the feature everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
dummy-for-ci-checkfeature was added to avoid breaking Agave's CI when the sdk was put into its own workspace, but it isn't actually needed bysolana-sdknow that it's out of the Agave repo.Summary of changes
Remove the feature everywhere.