stable-layout: change fields visibility of StableVec<T> from public to private#740
Open
yilin0518 wants to merge 1 commit into
Open
stable-layout: change fields visibility of StableVec<T> from public to private#740yilin0518 wants to merge 1 commit into
yilin0518 wants to merge 1 commit into
Conversation
…o private and add cap() method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request solves the issue #615 which mentions that public fields may have potential risks. This PR makes improvements to the
StableVecstruct in thestable-layoutcrate, focusing on encapsulation and API usability. The most important changes are:Encapsulation improvements:
addr,cap, andlenin theStableVecstruct from public to private, preventing direct modification from outside the struct and improving safety.API enhancements:
cap()to theStableVecimplementation, allowing users to access the capacity of the vector in a controlled manner.