Skip to content

Fix: BaseWalletConnection doesn't pass thru classname prop #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asktree wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: BaseWalletConnection doesn't pass thru classname prop #967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/ui/react-ui/src/BaseWalletConnectionButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
import type { WalletName } from '@solana/wallet-adapter-base';
import React from 'react';
import type { ButtonProps } from './Button.js';
import { Button } from './Button.js';
import { WalletIcon } from './WalletIcon.js';

type Props = React.ComponentProps<typeof Button> & {
type Props = ButtonProps & {
Copy link
Author

@asktree asktree May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this type change because eslint/prop-types was complaining that className was not among the props, ostensibly this is a bug in the rule. I'm not sure this prop-types rule does anything if you're using strict ts anyway.

walletIcon?: string;
walletName?: WalletName;
};

export function BaseWalletConnectionButton({ walletIcon, walletName, ...props }: Props) {
export function BaseWalletConnectionButton({ walletIcon, walletName, className, ...props }: Props) {
return (
<Button
{...props}
className="wallet-adapter-button-trigger"
className={'wallet-adapter-button-trigger ' + (className ?? '')}
startIcon={
walletIcon && walletName ? (
<WalletIcon wallet={{ adapter: { icon: walletIcon, name: walletName } }} />
Expand Down