Skip to content

Fixed an issue where the player would get stuck on one song after playing for about an hour or so#687

Open
alexjyong wants to merge 37 commits into
aome510:masterfrom
alexjyong:revamp-token-refreshing
Open

Fixed an issue where the player would get stuck on one song after playing for about an hour or so#687
alexjyong wants to merge 37 commits into
aome510:masterfrom
alexjyong:revamp-token-refreshing

Conversation

@alexjyong
Copy link
Copy Markdown

@alexjyong alexjyong commented Mar 4, 2025

Partially fixes #603

Looks like we weren't loading the new auth token into the Session when it got refreshed.

Unfortunately, this doesn't seem to be a complete fix, as I see the issue crop up sometimes, and the current page you are on the UI will have to be manually refreshed when the token expires (i.e. navigating to another page seems to help)

It does however, reduce the frequency when it happens. It seems to be the most stable when you get a long playlist running and let it be for a bit.

@aome510
Copy link
Copy Markdown
Owner

aome510 commented Mar 24, 2025

Looks like we weren't loading the new auth token into the Session when it got refreshed.

I don't think this is the case. I haven't been following the original issue but I'm pretty sure that librespot session implements a token refetching logic itself. The auth token that spotify_player implements refetching is used by the Spotify client to make API requests not used by librespot session

@alexjyong
Copy link
Copy Markdown
Author

@aome510 yeah I'm not 100% sure. I noticed the frequency of the "stuck in one song" issues went down a bit, but not completely. I posted some logs in the original issue.

@aome510
Copy link
Copy Markdown
Owner

aome510 commented Mar 25, 2025

@aome510 yeah I'm not 100% sure. I noticed the frequency of the "stuck in one song" issues went down a bit, but not completely. I posted some logs in the original issue.

Thank you for investigating! I'll take a deeper look when I get more time

@alexjyong
Copy link
Copy Markdown
Author

Hi @aome510 , any updates on this from your end? Just curious :)

@aome510
Copy link
Copy Markdown
Owner

aome510 commented Jun 4, 2025

Hi @aome510 , any updates on this from your end? Just curious :)

Sorry, I don't have any update. Couldn't really reproduce the issue on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Player got stuck in one song

2 participants