Addressing lto #160
Merged
Addressing lto #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the illegal instruction issue when -flto flag is used (link time optimization) as details in this thread
https://bugzilla.redhat.com/show_bug.cgi?id=2307795
It is not clear to me why the problem is happening.
The solution was to move the call to initialize the encoder tables from a static call to initialize a global static variable to a call during code execution, named initialize_block_encoder_tables().
The other changes are also to remove LTO compiler warnings.
I also updated FetchContent_Populate to FetchContent_MakeAvailable.