apps: ojph_sockets: Detect __GLIBC__ before using GNU-flavour strerror_r #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to manpage, glibc is the only libc implementation whose strerror_r() may return a char * pointer instead of int. Let's guard usage of the GNU-flavour prototype, instead of the standard XSI one. This should fix compilation on musl, *BSD and etc. Signed-off-by: Yao Zi <[email protected]>
Owner
|
Dear Yao, Thank you for putting this PR, and sorry for not getting back to you earlier. Kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to manpage, glibc is the only libc implementation whose strerror_r() may return a char * pointer instead of int. Let's guard usage of the GNU-flavour prototype, instead of the standard XSI one. This should fix compilation on musl, *BSD and etc.