Skip to content

Grammar, content, and type changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

nate-lord-ww
Copy link
Collaborator

No description provided.

@nate-lord-ww nate-lord-ww requested a review from aoxrud March 9, 2021 18:08

```html
<svg>
<title>description of svg</title>
</svg>
```

1. Hide the svg via `aria-hidden="true"` and add a visually hidden element that describes it.
2. Hide the svg via `aria-hidden="true"` and add a visually hidden element that describes it.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In markdown you can prefix each item in list with 1. and markdown will take care of enumerating it. This makes it easier to reorder lines without having to manually change the numbers in each line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoxrud-ww I'd normally agree with that method but bc of the html blocks separating them they were both rendered as 1.

Screen Shot 2021-03-10 at 4 48 09 PM

Assistive technologies wouldn't announce the disabled styling so the disabled state should be indicated using the [aria-disabled](https://www.digitala11y.com/aria-disabled-state/) attribute.

For example: a button needs to be shown as disabled and it should still be clickable.
Maybe clicking on the disabled button triggers a validation announcement.
There are exceptions where the inputs are styled as visually disabled and they don't have the `disabled` attribute declared. For example: a checkbox needs to be visually disabled but it should still be focusable. We'd want this so its content is still accessible to the screen reader.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this checkbox example is an actual use-case. We wouldn't denote a checkbox as disabled but still have it checkable. It would be conflicting information to the user.
We did use the pattern where buttons are disabled but still clickable and when you do that it triggers the form validation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aoxrud-ww I was confused here. I thought aria-disabled hid elements from the screen reader but that's not the case. That being said I think this section could benefit from a brief discussion of disabled vs aria-disabled

Suggested change
There are exceptions where the inputs are styled as visually disabled and they don't have the `disabled` attribute declared. For example: a checkbox needs to be visually disabled but it should still be focusable. We'd want this so its content is still accessible to the screen reader.
For example: a button needs to be shown as disabled and it should still be clickable.
Maybe clicking on the disabled button triggers a validation announcement.
It's important to note that the `disabled` attribute will hide the element from the screen reader. This should be avoided because although the element is disabled it still provides valuable information to the user. For example if a next button has a `disabled` (instead of an `aria-disabled`) attribute by default until some condition is met that button will be hidden from the screen reader. Knowing that there **is** a next button and it's disabled is valuable information which can be conveyed through `aria-disabled`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants