Make several TableOpsImpl methods atomic #5540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
approved these changes
May 9, 2025
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
Outdated
Show resolved
Hide resolved
kevinrr888
approved these changes
May 16, 2025
ctubbsii
reviewed
May 19, 2025
| } | ||
|
|
||
| @Override | ||
| public void clearSamplerConfiguration(String tableName) | ||
| throws AccumuloException, TableNotFoundException, AccumuloSecurityException { | ||
| throws AccumuloException, AccumuloSecurityException { |
There was a problem hiding this comment.
Why would this no longer throw TableNotFoundException? That seems odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5494
This PR replaces places were multiple calls to set or remove properties were being done with a single modify properties block to make things atomic. The affected methods are: