Simplify conversions from java.nio.file.Path to File #5547
Conversation
| return file.getAbsolutePath(); | ||
| Path path = Path.of(keystorePath); | ||
| if (Files.exists(path)) { | ||
| return path.toAbsolutePath().toString(); |
There was a problem hiding this comment.
This is a private method. It can return the absolute path without converting it to a string. The calling code can keep it as a path or convert it as needed. That reduces the assumptions this code makes on how it is used by the callers.
| if (keystoreFile.exists()) { | ||
| if (!keystoreFile.delete()) { | ||
| log.error("Unable to delete {}", keystoreFile); | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm a little confused why the file deletion was removed from these changes. It seems like the file is supposed to get re-created, or something, and this cleaned up the old one if it existed from a previous build. My guess is that behavior is still desired.
| Map<String,String> contents = ClusterConfigParser | ||
| .parseConfiguration(Path.of(configFile.toURI()).toFile().getAbsolutePath()); | ||
| .parseConfiguration(Path.of(configFile.toURI()).toAbsolutePath().toString()); |
There was a problem hiding this comment.
ClusterConfigParser could take a Path object instead of a String. That would simplify this further, and make it more type-safe. ClusterConfigParser is only used internally.
No description provided.