Simplify conversions from java.nio.file.Path to File

[DomGarguilo]

No description provided.

[ctubbsii]

A lot of these changes are nice. There is some potential to move further away from String-types in some of the method return types and parameter types, to improve type safety.

[DomGarguilo]

I've marked this as ready for review. I've gone through all the places that call .toFile() or otherwise could be simplified to reduce converting to/from a File object and opted to use Path instead where it made sense.

[kevinrr888]

I haven't finished reviewing, I'll finish on Monday. Posting my comments so far, most comments are repeats

It would be good to run the full set of tests for this PR as well.

[DomGarguilo]

@kevinrr888 i pushed up 9891482 to address some of your comments.

Regarding all the comments suggesting to assertTrue(Files.isDirectory(dir)) or similar with a file, Files.isDirectory will throw an exception if it does not properly create a directory at the given path. So in most (if not all) cases here, we can rely on that exception to alert us about any failure and if no exception is thrown, we can safely assume that things were created properly. Same goes for the Files.createFile()

[kevinrr888]

Regarding all the comments suggesting to assertTrue(Files.isDirectory(dir)) or similar with a file, Files.isDirectory will throw an exception if it does not properly create a directory at the given path. So in most (if not all) cases here, we can rely on that exception to alert us about any failure and if no exception is thrown, we can safely assume that things were created properly. Same goes for the Files.createFile()

Ah I see, feel free to resolve all those comments.
I remember seeing places where you do include the assertion assertTrue(Files.isDirectory(dir)) after the creation, which is why I thought we should be ensuring it actually exists. Maybe could remove those assertions?

[kevinrr888]

should this be MiniAccumuloClusterClasspathTest?

[kevinrr888]

These changes LGTM so long as the full set of tests pass