Skip to content

Fix to some shared mini cluster ITs #5579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.1
Choose a base branch
from

Conversation

kevinrr888
Copy link
Member

Some mini cluster ITs were missing a
SharedMiniClusterBase.stopMiniCluster() in a JUnit AfterAll. Added to those that were missing.

This has already been fixed in main by #5555

Mini cluster needs to be started in a BeforeAll with SharedMiniClusterBase.startMiniCluster() or SharedMiniClusterBase.startMiniClusterWithConfig(...) and stopped in an AfterAll with SharedMiniClusterBase.stopMiniCluster(), so used:

$ grep -rl --include *.java "startMiniCluster" . | xargs grep -L "stopMiniCluster"

To identify tests not adhering to this

Some mini cluster ITs were missing a
`SharedMiniClusterBase.stopMiniCluster()` in a JUnit AfterAll. Added to
those that were missing.
@kevinrr888 kevinrr888 added this to the 2.1.4 milestone May 22, 2025
@kevinrr888 kevinrr888 self-assigned this May 22, 2025
@ctubbsii
Copy link
Member

There are two tests that match in the main branch. It might be good to add a comment on those explaining that stop is called in the super class.

Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why we couldn't do this in the Abstract base class, but I think I remember that we couldn't for some reason.

These are good changes.

We have some ci scripts in src/build/ci/ ; you could add one there that does the check for classes that match, and then call it in .github/workflows/maven.yaml's fastbuild after the other checks.

@ctubbsii
Copy link
Member

I went ahead and added the automated CI checks I was talking about.

@ctubbsii
Copy link
Member

This is ready to merge. When merging forward to the main branch, there are a few lines to modify in the CI script. However, there is currently a merge conflict from #5571 that will need to be merged into main and resolved first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants