Fix locale-dependent string comparison in direct_field_access test#2439
Merged
jrgemignani merged 1 commit intoJun 11, 2026
Merged
Conversation
Replace 'test' > 'TEST' with deterministic 'abd' > 'abc'. The original comparison returns different results depending on system collation settings (true under C locale, false under en_US.UTF-8).
There was a problem hiding this comment.
Pull request overview
This PR makes the direct_field_access regression test deterministic across different system collations by replacing a locale-sensitive string comparison with one that should evaluate consistently.
Changes:
- Updated the Cypher string “greater-than” comparison in
direct_field_access.sqlto avoid collation-dependent behavior. - Updated the corresponding expected regression output to match the new test query.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| regress/sql/direct_field_access.sql | Replaces a locale-dependent string comparison with a deterministic one in the scalar comparison test. |
| regress/expected/direct_field_access.out | Updates expected output to match the modified regression query. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jrgemignani
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
'test' > 'TEST'with deterministic'abd' > 'abc'. The original comparison returns different results depending on system collation settings (trueunderClocale,falseunderen_US.UTF-8).