Skip to content

Wire role management tab to RBAC APIs - #524

Merged
lahirujayathilake merged 5 commits into
apache:masterfrom
jayvenn21:jayanth/role-management-tab
Jul 16, 2026
Merged

Wire role management tab to RBAC APIs#524
lahirujayathilake merged 5 commits into
apache:masterfrom
jayvenn21:jayanth/role-management-tab

Conversation

@jayvenn21

@jayvenn21 jayvenn21 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a Role Management data layer for Custos RBAC role endpoints
  • wire the admin Role Management tab to list roles, load privileges/member counts, create/update roles, and add/remove role privileges
  • add MSW handlers and an e2e test for the role-management flow
  • fix existing portal compile issues in the account menu/nav and Playwright auth fixture

Testing

  • PATH=/opt/homebrew/opt/node@22/bin:$PATH corepack pnpm typecheck
  • PATH=/opt/homebrew/opt/node@22/bin:$PATH corepack pnpm lint
  • PATH=/opt/homebrew/opt/node@22/bin:$PATH corepack pnpm test
  • PATH=/opt/homebrew/opt/node@22/bin:$PATH corepack pnpm exec playwright test tests/role-management.e2e.ts --timeout=60000
  • go test ./...

Built on top of merged PR #520 and current master (#523/#521 included).

@jayvenn21
jayvenn21 force-pushed the jayanth/role-management-tab branch from 79886b6 to 5807cf1 Compare July 14, 2026 00:00

@lahirujayathilake lahirujayathilake left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayvenn21 thanks for the PR. I have added some review comments.

Comment thread web/src/app/(portal)/admin/users/roles/RoleCard.tsx
Comment thread web/src/app/(portal)/admin/users/roles/PermissionMatrixEditor.tsx Outdated
Comment thread web/src/shared/users-admin/permissions.ts Outdated
Comment thread web/src/shared/layout/UserPill.tsx Outdated
Comment thread web/src/shared/layout/nav.ts
@jayvenn21

Copy link
Copy Markdown
Contributor Author

@lahirujayathilake thanks for the feedback, i've made some changes with a new commit addressing the review. please take a look if there are any further changes to be made

@lahirujayathilake
lahirujayathilake self-requested a review July 14, 2026 16:49

@lahirujayathilake lahirujayathilake left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayvenn21 , I have added some comments and some need clarifications. Can you check those?

Comment thread web/src/features/core/roles/queries.ts Outdated
Comment thread web/src/features/core/roles/schemas.ts
Comment thread web/tests/fixtures/auth.ts Outdated
Comment thread web/src/app/(portal)/admin/users/roles/RoleCard.tsx
Comment thread web/src/shared/users-admin/permissions.ts Outdated
Comment thread web/src/app/(portal)/admin/users/roles/RoleFormDialog.tsx
@jayvenn21

Copy link
Copy Markdown
Contributor Author

@lahirujayathilake I've addressed all the feedback in the latest commit, please let me know if there are any further changes to be made

@lahirujayathilake
lahirujayathilake self-requested a review July 16, 2026 10:37
@lahirujayathilake

Copy link
Copy Markdown
Member

@jayvenn21 LGTM 👍🏼

@lahirujayathilake
lahirujayathilake merged commit 7eaab4e into apache:master Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants