Skip to content

skip setproctitle in task_runner on Mac OS #45124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

jaketf
Copy link
Contributor

@jaketf jaketf commented Dec 20, 2024

On some newer versions of Mac OS setproctitle can cause segfault benoitc/gunicorn#3021


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've started noticed this causing tests on OSX to fail on occassion, but hadn't noticed any runtime issues. Makes sense though.

There are probably a few other cases where we setproctitle (in the dag parser code I just landed inside airflow/dag_processor/ could you update those too?)

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 23, 2025
@github-actions github-actions bot closed this Mar 1, 2025
@kaxil kaxil reopened this Apr 9, 2025
On some newer versions of Mac OS setproctitle can cause segfault benoitc/gunicorn#3021
@kaxil kaxil marked this pull request as ready for review April 9, 2025 14:43
@kaxil kaxil requested review from kaxil and amoghrajesh as code owners April 9, 2025 14:43
@ashb ashb merged commit a5fd5bb into apache:main Apr 9, 2025
66 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:task-sdk stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants