Port cache classes: SecretCache to Task SDK
#49779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhusneha
requested review from
XD-DENG,
amoghrajesh,
ashb,
dstandish,
kaxil and
potiuk
as code owners
1 task
prabhusneha
requested review from
ephraimbuddy and
jedcunningham
as code owners
amoghrajesh
approved these changes
Apr 28, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
One comment, sounds fine by me. I do not have a very strong opinion whether it should be in cache.py under execution_time or some other name. I'm as long as its in the execution_time as we will import it with its short name anyways.
@kaxil WDYT?
amoghrajesh
reviewed
Apr 29, 2025
Lee-W
reviewed
Apr 30, 2025
Lee-W
reviewed
Apr 30, 2025
amoghrajesh
changed the title
SecretCache to Task SDK
Lee-W
approved these changes
May 5, 2025
Contributor
|
@Lee-W since this was a porting effort, I have dismissed your nits, i will follow it up dont worry :D |
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #48833