Skip to content

Fix serde recursion limit test by using correct MAX_RECURSION_DEPTH #61182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eason09053360 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Fix serde recursion limit test by using correct MAX_RECURSION_DEPTH #61182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion task-sdk/tests/task_sdk/serde/test_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

from airflow.sdk._shared.module_loading import qualname
from airflow.sdk.definitions.param import Param, ParamsDict
from airflow.sdk.serde import CLASSNAME, DATA, VERSION, decode, deserialize, serialize
from airflow.sdk.serde import CLASSNAME, DATA, VERSION, decode, deserialize, serialize, MAX_RECURSION_DEPTH
from airflow.sdk.serde.serializers import builtin

from tests_common.test_utils.markers import skip_if_force_lowest_dependencies_marker
Expand Down Expand Up @@ -675,3 +675,7 @@ def test_uuid_roundtrip(self, uuid_value):
deserialized = deserialize(serialized)
assert isinstance(deserialized, uuid.UUID)
assert uuid_value == deserialized
def test_serde_serialize_recursion_limit(self):
depth = MAX_RECURSION_DEPTH
with pytest.raises(RecursionError, match="maximum recursion depth reached for serialization"):
serialize(object(), depth=depth)
Comment on lines +678 to +681
Copy link
Contributor

@amoghrajesh amoghrajesh Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you fixing a test or adding a new one?

Copy link
Author

@Eason09053360 Eason09053360 Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fixing a test (readding a previously removed flaky test with a fix)

Copy link
Contributor

@henry3260 henry3260 Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amoghrajesh It’s more like a fix, I think, because someone found this test was flaky and just deleted it.
FYI #51737

Loading