Update msgraph.py to_msal_proxies #61199
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the logic of function to_msal_proxies. Return proxies attribute even when the authority is not filled
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*closes: #61197
To be honest, this PR is only a draft. From the Code I can see that Authority can be retrieved from connection as an extra parameter. However, there is no information about it in the documentation.
So, this is a little bit confusing when using the proxy. So I propose to update the logic of a function to_msal_proxies. Return proxies attribute even when the variable authority is not filled.
Testing
In our environment I did a functional logic test with and without proxy. It works as expected