Skip to content

Fix: allow deadline alert UUID references in serialized Dag schema#68195

Open
sjyangkevin wants to merge 1 commit into
apache:mainfrom
sjyangkevin:fix/deadline-schema-uuid-refs
Open

Fix: allow deadline alert UUID references in serialized Dag schema#68195
sjyangkevin wants to merge 1 commit into
apache:mainfrom
sjyangkevin:fix/deadline-schema-uuid-refs

Conversation

@sjyangkevin
Copy link
Copy Markdown
Contributor

When a Dag defines a deadline alert, the alert is stored in its own deadline_alert table on write, and SerializedDagModel._generate_deadline_uuids rewrites the serialized Dag's deadline field from a list of encoded dicts into a list of UUID strings pointing at those rows. However, schema.json only allowed deadline to be a dict, an array of dicts, or null. As a result, validating the stored serialized Dag for any deadline-bearing Dag fails with something like:

FAILED airflow-core/tests/unit/models/test_serialized_dag.py::TestSerializedDagModel::test_write_dag[compress-serialized_dags] - jsonschema.exceptions.ValidationError: ['019ea3de-70d1-77ec-82b1-0dceeb508be5'] is not valid under any of the given schemas

Failed validating 'anyOf' in schema['allOf'][0]['properties']['dag']['properties']['deadline']:
    {'anyOf': [{'$ref': '#/definitions/dict'},
               {'items': {'$ref': '#/definitions/dict'}, 'type': 'array'},
               {'type': 'null'}]}

On instance['dag']['deadline']:
    ['019ea3de-70d1-77ec-82b1-0dceeb508be5']

Fix

  • Adds an array of string option to the deadline schema so it accepts the persisted UUID-reference format.
  • Adds a regression test that writes a deadline-bearing Dag and asserts the stored data passes schema validation, guarding against the schema and storage format drifting apart again.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Code (Opus 4.8)] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@sjyangkevin sjyangkevin marked this pull request as ready for review June 8, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant